Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CUDA 12.0 for pip wheels #13289

Merged
merged 21 commits into from
May 5, 2023
Merged

Support CUDA 12.0 for pip wheels #13289

merged 21 commits into from
May 5, 2023

Conversation

divyegala
Copy link
Member

@divyegala divyegala commented May 4, 2023 •
edited by vyasr
Loading

Description

In addition to switching to the new workflow for building on CUDA 12 images, this PR includes changes to:

  • Use a CUDA version-specific package name when downloading cudf during dask-cudf testing
  • Update pyproject dependencies for packages that are either unnecessary in CUDA 12 (ptxcompiler/cubinlinker) or need different names/versions (cuda-python or cupy-cuda11x vs 12x).
  • Add an upper bound pinning on numpy. numpy 1.24.3 adds some deprecation warnings that cause our test suite to fail. Addressing these is being worked on in parallel.
  • Ensure that cubinlinker is never imported when it is not available.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@divyegala divyegala requested review from a team as code owners May 4, 2023 03:30
@divyegala divyegala requested review from vyasr and charlesbluca May 4, 2023 03:30
@github-actions github-actions bot added ci Python Affects Python cuDF API. labels May 4, 2023
@github-actions github-actions bot added the conda label May 4, 2023
@divyegala divyegala added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 4, 2023
ajschmidt8
ajschmidt8 approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@bdice bdice mentioned this pull request May 4, 2023
Merged
3 tasks
bdice
bdice approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion.

.github/workflows/pr.yaml Show resolved Hide resolved
vyasr
vyasr approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the interest of getting CUDA 12 wheels up ASAP, I'm going to approve this despite being involved in the dev so that we can start running cuml and cugraph tests. However, I encourage other reviewers to still leave comments on here even after it's merged so that we can come back and address them.

@vyasr vyasr mentioned this pull request May 5, 2023
Closed
@vyasr
Copy link
Contributor

vyasr commented May 5, 2023

In the interest of letting cuml and cugraph CI run ASAP, I'm going to merge this PR then make a small follow-up to address the two open discussions above.

@vyasr
Copy link
Contributor

vyasr commented May 5, 2023

/merge

@rapids-bot rapids-bot bot merged commit 72e37e4 into rapidsai:branch-23.06 May 5, 2023
@vyasr vyasr mentioned this pull request May 5, 2023
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request May 8, 2023
@vyasr
Address feedback from 13289 (#13306)
5b534a3 
This PR addresses a couple of minor items that were left incomplete when #13289 was merged, see #13289 and #13289.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)
  - Bradley Dice (https://github.com/bdice)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #13306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@wence- wence- wence- left review comments

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@pentschev pentschev pentschev approved these changes

@bdice bdice bdice approved these changes

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@divyegala @vyasr @wence- @bdice @pentschev @ajschmidt8