Add an event handler for ColumnVector.close #13279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Bellina <[email protected]>
abellina
added
feature request
gerashegalov
approved these changes
May 2, 2023
jlowe
reviewed
May 3, 2023
jlowe
approved these changes
May 3, 2023
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 18, 2023
) This change adds the exact same API for event handling that was added to the device-side `ColumnVector` here #13279. We are going to need this to make `HostColumnVector`, or a batch of them, spillable in this spark-rapids feature: NVIDIA/spark-rapids#8882. Authors: - Alessandro Bellina (https://github.com/abellina) Approvers: - Gera Shegalov (https://github.com/gerashegalov) - Robert (Bobby) Evans (https://github.com/revans2) URL: #13898
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an event handler for
ColumnVectorto be invoked when.close()is invoked.I also made
getRefCountpublic since it is useful for debugging and I couldn't think of a good reason to keep this hidden.This event handler is used to keep track of what columns are spillable at a time and is part of NVIDIA/spark-rapids#7672.
Checklist