Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default null-count parameter from some libcudf factory functions #13258

Merged
merged 13 commits into from
May 5, 2023
Merged

Remove default null-count parameter from some libcudf factory functions #13258

merged 13 commits into from
May 5, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Removes the UNKNOWN_NULL_COUNT as the default value for the null-count parameter for cudf::make_fixed_point_column and cudf::make_numeric_column factory functions.
Also fixes some places where the stream parameter was not being passed along.

Labeling this with breaking since it is a public function.

Contributes to: #11968

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 1, 2023
@davidwendt davidwendt self-assigned this May 1, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels May 2, 2023
@davidwendt davidwendt marked this pull request as ready for review May 2, 2023 11:24
@davidwendt davidwendt requested a review from a team as a code owner May 2, 2023 11:24
@davidwendt davidwendt requested a review from a team as a code owner May 4, 2023 16:37
@github-actions github-actions bot added the Java Affects Java cuDF API. label May 4, 2023
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit fce2f0b into rapidsai:branch-23.06 May 5, 2023
@davidwendt davidwendt deleted the factory-null-count-parms branch May 5, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@hyperbolic2346 hyperbolic2346 Awaiting requested review from hyperbolic2346 hyperbolic2346 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @karthikeyann @ttnghia @vyasr