Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and clarify notes on result ordering #13255

Merged
merged 6 commits into from
Apr 12, 2024
Merged

Fix and clarify notes on result ordering #13255

merged 6 commits into from
Apr 12, 2024

Conversation

shwina
Copy link
Contributor

@shwina shwina commented May 1, 2023

I noticed when answering #13254 that the code example in this section of our documentation was incorrect and the text itself could use some improving.

wence-
wence- reviewed May 2, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicks

docs/cudf/source/user_guide/pandas-comparison.md Outdated Show resolved Hide resolved
docs/cudf/source/user_guide/pandas-comparison.md Outdated Show resolved Hide resolved
docs/cudf/source/user_guide/pandas-comparison.md Show resolved Hide resolved
docs/cudf/source/user_guide/pandas-comparison.md Outdated Show resolved Hide resolved
@shwina shwina self-assigned this May 18, 2023
@shwina shwina changed the base branch from branch-23.06 to branch-23.08 May 26, 2023 15:26
@vyasr vyasr changed the base branch from branch-23.08 to branch-24.02 January 19, 2024 17:09
@vyasr
Copy link
Contributor

vyasr commented Jan 19, 2024

@shwina @wence- the docs have been updated from underneath this PR, so it needs some conflict resolution. Do you want to fix up the wording to something that you both like?

@shwina shwina requested review from a team as code owners April 11, 2024 20:39
@shwina shwina requested review from bdice, isVoid and karthikeyann and removed request for a team April 11, 2024 20:40
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 11, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. CMake CMake build issue conda Java Affects Java cuDF API. labels Apr 11, 2024
@vyasr vyasr changed the base branch from branch-24.02 to branch-24.06 April 11, 2024 20:43
@vyasr vyasr requested review from wence- and removed request for a team, bdice, isVoid and karthikeyann April 11, 2024 20:43
@vyasr vyasr added doc Documentation non-breaking Non-breaking change and removed libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue conda Java Affects Java cuDF API. labels Apr 11, 2024
@vyasr
Copy link
Contributor

vyasr commented Apr 11, 2024

/ok to test

@wence-
Copy link
Contributor

wence- commented Apr 11, 2024

/merge

@rapids-bot rapids-bot bot merged commit ff22a7a into rapidsai:branch-24.06 Apr 12, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr left review comments

@wence- wence- wence- approved these changes

Assignees

@shwina shwina

Labels
doc Documentation non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shwina @vyasr @wence-