Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty input table in ast compute_column #13245

Merged
merged 4 commits into from
May 2, 2023

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Apr 28, 2023

Description

If the input table is empty we can still produce an output of
appropriate type by letting the parser run and inferring types.
In this case though, we do not want to actually run a kernel,
since we would try and launch with zero blocks which is not
allowed.

Closes #13236.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence- wence- added bug Something isn't working non-breaking Non-breaking change labels Apr 28, 2023
@wence- wence- requested review from a team as code owners April 28, 2023 10:41
@wence- wence- self-assigned this Apr 28, 2023
@github-actions github-actions bot added Python Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Apr 28, 2023
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

@wence-
Copy link
Contributor Author

wence- commented May 2, 2023

/merge

@rapids-bot rapids-bot bot merged commit dfacb95 into rapidsai:branch-23.06 May 2, 2023
@wence- wence- deleted the wence/fix/issue-13236 branch May 9, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] AST fails with zero-row inputs
3 participants