-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make is_decompression_disabled
and is_compression_disabled
thread-safe
#13240
Make is_decompression_disabled
and is_compression_disabled
thread-safe
#13240
Conversation
is_decompression_disabled
and is_compression_disabled
thread safeis_decompression_disabled
and is_compression_disabled
thread-safe
I wonder if we can just call |
Yes, we could. I only added this mechanism to be able to log the result of each query once. Otherwise we would either need a similar map for logging, or we would have to allow logs to be very repetitive. |
@vuule I ran with this and it did not reproduce. Thanks for the quick fix. |
We are hitting all kinds of segfaults in CI that I think are all related to this issue: NVIDIA/spark-rapids#8194, so the spark-rapids CI is currently blocked or limping along. Could we merge @vuule's solution and then perhaps follow up with more modifications if the memoization approach should be modified? |
/merge |
Description
Adds a mutex to guard the use of the memoization map for the status of nvCOMP features.
Checklist