Ensure cccl packages don't clash with upstream version #13235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
feature request
github-actions
bot
added
CMake
bdice
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
Looks good. @robertmaynard We should chat today about a merge plan for some of the rapids-cmake work in flight. I think I know what order current work should merge but would be good to confirm with you.
4 tasks
vyasr
approved these changes
May 23, 2023
| rapids_export_find_package_root( | ||
| INSTALL | ||
| libcudacxx | ||
| [=[${CMAKE_CURRENT_LIST_DIR}/../../../include/libcudf/lib/rapids/cmake/libcudacxx]=] |
There was a problem hiding this comment.
If we ever need to store other patched libraries like this it would be nice to store this path in some central location, but probably not worth it right now.
|
@robertmaynard Is this ready to merge? |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on: rapidsai/rapids-cmake#393
Once the above PR is merged, this updated logic ensures that cudf places the custom versions of cccl packages in correct places, and can find them once installed.
Checklist