Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default null-count parameter from cudf::make_strings_column factory #13227

Merged
merged 12 commits into from
May 4, 2023
Merged

Remove default null-count parameter from cudf::make_strings_column factory #13227

merged 12 commits into from
May 4, 2023

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Apr 26, 2023 •
edited
Loading

Description

Removes the UNKNOWN_NULL_COUNT default parameter from cudf::make_strings_column factory functions and updates the callers to always pass the null-count.

Labeling this with breaking since it is a public function.

Contributes to: #11968

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 26, 2023
@davidwendt davidwendt self-assigned this Apr 26, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Apr 28, 2023
@davidwendt davidwendt marked this pull request as ready for review April 28, 2023 17:40
@davidwendt davidwendt requested a review from a team as a code owner April 28, 2023 17:40
@davidwendt davidwendt requested a review from karthikeyann May 2, 2023 11:30
@davidwendt davidwendt added breaking Breaking change and removed non-breaking Non-breaking change labels May 2, 2023
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 49b6eaf into rapidsai:branch-23.06 May 4, 2023
@davidwendt davidwendt deleted the strings-factory-null-count branch May 4, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikeyann karthikeyann karthikeyann approved these changes

@harrism harrism harrism approved these changes

@robertmaynard robertmaynard Awaiting requested review from robertmaynard robertmaynard is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@vyasr vyasr Awaiting requested review from vyasr

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @harrism @karthikeyann