Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kurtosis pytests to support numeric_only parameter #13217

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Fix kurtosis pytests to support numeric_only parameter #13217

merged 2 commits into from
Apr 27, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

#12847 introduced support for numeric_only, this PR cleans up a kurt related pytest that was relying on the old behavior.

This PR fixes 18 pytests :

= 413 failed, 88257 passed, 2044 skipped, 932 xfailed, 165 xpassed in 463.03s (0:07:43) =

On pandas_2.0_feature_branch:

= 431 failed, 88221 passed, 2044 skipped, 932 xfailed, 165 xpassed in 456.25s (0:07:36) =

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Apr 25, 2023
@galipremsagar galipremsagar self-assigned this Apr 25, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner April 25, 2023 19:27
@galipremsagar galipremsagar mentioned this pull request Apr 25, 2023
Closed
@galipremsagar galipremsagar changed the title [REVIEW] Fix kurtosis pytests to support numeric_only parameter Fix kurtosis pytests to support numeric_only parameter Apr 26, 2023
@galipremsagar galipremsagar merged commit 569b3e7 into rapidsai:pandas_2.0_feature_branch Apr 27, 2023
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@shwina shwina Awaiting requested review from shwina

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @mroeschke