Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UNKNOWN_NULL_COUNT where it can be easily computed #13205

Merged
merged 9 commits into from
Apr 26, 2023
Merged

Remove UNKNOWN_NULL_COUNT where it can be easily computed #13205

merged 9 commits into from
Apr 26, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Apr 24, 2023

Description

Contributes to #11968

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 24, 2023
@vyasr vyasr added this to the Enable streams milestone Apr 24, 2023
@vyasr vyasr self-assigned this Apr 24, 2023
@vyasr vyasr requested a review from a team as a code owner April 24, 2023 17:35
@vyasr vyasr requested review from divyegala and davidwendt April 24, 2023 17:35
@vyasr vyasr added breaking Breaking change and removed non-breaking Non-breaking change labels Apr 25, 2023
@vyasr vyasr requested a review from ttnghia April 25, 2023 23:10
ttnghia
ttnghia approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@ttnghia ttnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious: Can this be tested to check incorrect stream usage?

@ttnghia ttnghia mentioned this pull request Apr 26, 2023
Merged
@vyasr
Copy link
Contributor Author

vyasr commented Apr 26, 2023

I'm curious: Can this be tested to check incorrect stream usage?

Not quite yet, but we should be able to do so soon. There is some validation happening now, but I suspect that the validation you want to see is verifying that we're not accidentally falling back to cudf::get_default_stream() somewhere internally instead of passing the input stream through. We can't do that quite yet because at the moment the input stream is always cudf::get_default_stream(). Once we have stream parameters in public APIs we will be able to test this (or if we want to do it sooner, we could start testing detail APIs; that's a discussion we've had before and may again as we get closer to exposing streams).

@vyasr
Copy link
Contributor Author

vyasr commented Apr 26, 2023

/merge

@rapids-bot rapids-bot bot merged commit f4e0f19 into rapidsai:branch-23.06 Apr 26, 2023
@vyasr vyasr deleted the feat/null_count_struct_slice branch April 26, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@divyegala divyegala divyegala approved these changes

@ttnghia ttnghia ttnghia approved these changes

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
Enable streams
Development

Successfully merging this pull request may close these issues.
4 participants
@vyasr @ttnghia @divyegala @davidwendt