Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of rapids-get-rapids-version-from-git #13184

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Remove usage of rapids-get-rapids-version-from-git #13184

merged 2 commits into from
Apr 21, 2023

Conversation

jjacobelli
Copy link
Contributor

Description

Instead of using rapids-get-rapids-version-from-git we can just hardcode the version and use update-version.sh to update it

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jjacobelli jjacobelli added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 20, 2023
@jjacobelli jjacobelli self-assigned this Apr 20, 2023
@github-actions github-actions bot added the ci label Apr 20, 2023
@jjacobelli jjacobelli marked this pull request as ready for review April 20, 2023 17:19
@jjacobelli jjacobelli requested a review from a team as a code owner April 20, 2023 17:19
@ajschmidt8
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit b22f68e into rapidsai:branch-23.06 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees

@jjacobelli jjacobelli

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjacobelli @ajschmidt8