Enable mixed-dtype decimal/scalar binary operations #13171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shwina
added
improvement
|
Note to reviewers: this PR removes some previously xfailing tests. |
vyasr
approved these changes
Apr 19, 2023
charlesbluca
approved these changes
Apr 20, 2023
|
/merge |
wence-
reviewed
Apr 26, 2023
| metadata = other.as_tuple() | ||
| precision = max(len(metadata.digits), metadata.exponent) | ||
| scale = -metadata.exponent | ||
| return cudf.Scalar( |
There was a problem hiding this comment.
If other is Decimal should this not somehow end up going through the same normalisation as above with cudf.Scalar with decimal dtypes? Or does it not matter?
I'm pretty shaky on all the decimal stuff though, so ...
|
Merged trunk which will hopefully fix the wheelbuild fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also closes #13170