Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for DatetimeTZDtype and tz_localize #13163
Add support for DatetimeTZDtype and tz_localize #13163
Changes from 16 commits
c2b1968
fb293c0
3457063
6210054
cf67f8b
82ec81e
714116d
3a09e3d
8ed31eb
e72b3fc
d05e9e0
5b2c990
df3f7bc
a4f6430
8f4b215
b6ec602
54dc4d5
fad1c6a
4e89a5c
a473e51
1d18fcd
99cc4b0
6982474
b7563b8
a1141d8
fc5f497
22040ce
9e0f922
cfe5005
dcf49f8
8cd32f8
94aae6e
ffbcf42
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ValueError
seems more natural here unless you're matching something in pandas.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an issue in other places in this method and I just wanted to be consistent. Agree though that
ValueError
is the more appropriate error type. Let's fix in a follow-up.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this property error implementation be inherited from
DateTimeColumn
? Or if you think it's possible that CuPy might support time-zone-naive data (the parent class but not this zone-aware class), should we mention "time zone" in the error message?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope -- you're right, we should just inherit this