Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change some .cu gtest files to .cpp #13155

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Change some .cu gtest files to .cpp #13155

merged 2 commits into from
Apr 19, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Changed some libcudf gtests source files from .cu to .cpp by removing the unneeded thrust calls. This also simplified the logic a bit as well.
These were found while working on #13149

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 17, 2023
@davidwendt davidwendt self-assigned this Apr 17, 2023
@github-actions github-actions bot added the CMake CMake build issue label Apr 17, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Apr 18, 2023
@davidwendt davidwendt marked this pull request as ready for review April 18, 2023 21:52
@davidwendt davidwendt requested a review from a team as a code owner April 18, 2023 21:52
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 4f85f63 into rapidsai:branch-23.06 Apr 19, 2023
@davidwendt davidwendt deleted the gtests-cu-to-cpp branch April 19, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvdbaranec nvdbaranec nvdbaranec approved these changes

@bdice bdice bdice approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @robertmaynard @bdice @nvdbaranec