Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gtests to always pass null-count to set_null_mask calls #13148

Merged
merged 10 commits into from
Apr 20, 2023
Merged

Fix gtests to always pass null-count to set_null_mask calls #13148

merged 10 commits into from
Apr 20, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Fix calls to the column::set_null_mask() function to always pass the null-count value in gtests source files.

Contributes to: #11968

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 17, 2023
@davidwendt davidwendt self-assigned this Apr 17, 2023
@davidwendt davidwendt requested a review from a team as a code owner April 17, 2023 13:44
@davidwendt davidwendt requested review from vyasr and nvdbaranec April 17, 2023 13:44
ttnghia
ttnghia approved these changes Apr 17, 2023
View reviewed changes
cpp/tests/transform/nans_to_null_test.cpp Outdated Show resolved Hide resolved
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 09ca952 into rapidsai:branch-23.06 Apr 20, 2023
@davidwendt davidwendt deleted the tests-set-null-mask branch April 20, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice left review comments

@ttnghia ttnghia ttnghia approved these changes

@vyasr vyasr vyasr approved these changes

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @vyasr @bdice @ttnghia