Update clang-format to 16.0.1. #13133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
improvement
bdice
commented
Apr 14, 2023
cpp/scripts/run-clang-format.py
Outdated
There was a problem hiding this comment.
Can we remove this file? Our style enforcement is centrally handled by pre-commit. I just don't want to delete if some folks happen to rely on it.
There was a problem hiding this comment.
I use format-on-save and never touch that file.
There was a problem hiding this comment.
Ok. I will delete it.
ttnghia
approved these changes
Apr 14, 2023
|
The output of new clang version is much better IMO. |
elstehle
approved these changes
Apr 15, 2023
|
/merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
Fixes some build errors occuring after #13133 was merged. Looks like a couple files may have gotten mismerged perhaps. This should unblock several current PRs. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Yunsong Wang (https://github.com/PointKernel) - Divye Gala (https://github.com/divyegala) URL: #13146
shwina
pushed a commit
to shwina/cudf
that referenced
this pull request
Apr 18, 2023
This PR updates the clang-format version used by pre-commit. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Nghia Truong (https://github.com/ttnghia) - Elias Stehle (https://github.com/elstehle) URL: rapidsai#13133
shwina
pushed a commit
to shwina/cudf
that referenced
this pull request
Apr 18, 2023
Fixes some build errors occuring after rapidsai#13133 was merged. Looks like a couple files may have gotten mismerged perhaps. This should unblock several current PRs. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Yunsong Wang (https://github.com/PointKernel) - Divye Gala (https://github.com/divyegala) URL: rapidsai#13146
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the clang-format version used by pre-commit.