Add log messages about cuIO's nvCOMP and cuFile use #13132
Conversation
…fea-cuio-integration-logging
…fea-cuio-integration-logging
…fea-cuio-integration-logging
vuule
added
cuIO
…fea-cuio-integration-logging
…le/cudf into fea-cuio-integration-logging
| return lhs.lib_major_version == rhs.lib_major_version and | ||
| lhs.lib_minor_version == rhs.lib_minor_version and | ||
| lhs.lib_patch_version == rhs.lib_patch_version and | ||
| lhs.are_all_integrations_enabled == rhs.are_all_integrations_enabled and | ||
| lhs.are_stable_integrations_enabled == rhs.are_stable_integrations_enabled and | ||
| lhs.compute_capability_major == rhs.compute_capability_major; | ||
| } |
There was a problem hiding this comment.
I see that this cover all the members of feature_status_parameters. So the compiler should generate this operator == for you.
There was a problem hiding this comment.
Humnn, it seems that the default operator==() is available from C++ 20 :|
There was a problem hiding this comment.
yeah, it didn't work without the overload unfortunately.
| @@ -273,9 +273,18 @@ std::unique_ptr<cufile_input_impl> make_cufile_input(std::string const& filepath | |||
| { | |||
| if (cufile_integration::is_gds_enabled()) { | |||
| try { | |||
| return std::make_unique<cufile_input_impl>(filepath); | |||
| auto const cufile_in = std::make_unique<cufile_input_impl>(filepath); | |||
| CUDF_LOG_INFO("File successfully opened for reading with GDS."); | |||
There was a problem hiding this comment.
Do we need this log? It succeeds, and nothing special here?
There was a problem hiding this comment.
The goal of the messages in this PR is to provide some transparency into what method is used for file IO. We have direct use of GDS (this branch), no GDS (host IO + memcpy), and kvikIO. I included messages that make this selection apparent. FWIW, this is not the default branch, so very few users/devs will see this message.
I guess we can derive that lack of messages means that GDS is used, but I would prefer to log this case as INFO (off by default). If we find that this is too verbose, I'll remove some of these.
Co-authored-by: Nghia Truong <[email protected]>
…le/cudf into fea-cuio-integration-logging
…fea-cuio-integration-logging
|
/merge |
Description
Issue #7861
Added the following log messages:
Checklist