Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin curand version #13127

Merged
merged 6 commits into from
Apr 12, 2023
Merged

Pin curand version #13127

merged 6 commits into from
Apr 12, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Apr 12, 2023

Description

Merging the conda-forge curand recipe and building conda-forge packages has caused conda to choose a newer version of curand than what cudf currently supports (we cannot use the version from CUDA 12).

Closes #13126

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround conda non-breaking Non-breaking change labels Apr 12, 2023
@vyasr vyasr self-assigned this Apr 12, 2023
@vyasr vyasr requested a review from a team as a code owner April 12, 2023 17:18
@vyasr vyasr changed the base branch from branch-23.06 to branch-23.04 April 12, 2023 17:19
@robertmaynard
Copy link
Contributor

Fixes ##13126

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add libcurand[-dev] to dependencies.yaml? I think I would combine it with the cudatoolkit pinnings, as we do for raft.

@ttnghia ttnghia linked an issue Apr 12, 2023 that may be closed by this pull request
@raydouglass raydouglass requested a review from bdice April 12, 2023 19:22
@raydouglass raydouglass merged commit ed9385b into rapidsai:branch-23.04 Apr 12, 2023
@vyasr vyasr deleted the fix/pin_curand branch April 12, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Compile issue with curand.h
4 participants