-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin curand version #13127
Merged
Merged
Pin curand version #13127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
bug
Something isn't working
3 - Ready for Review
Ready for review by team
libcudf
Affects libcudf (C++/CUDA) code.
! - Hotfix
Hotfix is a bug that affects the majority of users for which there is no reasonable workaround
conda
non-breaking
Non-breaking change
labels
Apr 12, 2023
raydouglass
approved these changes
Apr 12, 2023
Fixes ##13126 |
robertmaynard
approved these changes
Apr 12, 2023
bdice
reviewed
Apr 12, 2023
…un requirements of libcudf-tests
bdice
reviewed
Apr 12, 2023
bdice
requested changes
Apr 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add libcurand[-dev]
to dependencies.yaml
? I think I would combine it with the cudatoolkit
pinnings, as we do for raft.
bdice
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
! - Hotfix
Hotfix is a bug that affects the majority of users for which there is no reasonable workaround
bug
Something isn't working
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merging the conda-forge curand recipe and building conda-forge packages has caused conda to choose a newer version of curand than what cudf currently supports (we cannot use the version from CUDA 12).
Closes #13126
Checklist