Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fix Series and DataFrame constructors to validate index lengths #13122

Merged
merged 6 commits into from
Apr 14, 2023
Merged

[REVIEW] Fix Series and DataFrame constructors to validate index lengths #13122

merged 6 commits into from
Apr 14, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes: #12999, #13056

This PR fixes the Series and DataFrame constructors to validate the data & index lengths. This also contains fixes where index was being ignored in certain cases.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Apr 12, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner April 12, 2023 00:39
@galipremsagar galipremsagar self-assigned this Apr 12, 2023
@galipremsagar galipremsagar requested review from vyasr and shwina April 12, 2023 00:39
@github-actions github-actions bot added the Python Affects Python cuDF API. label Apr 12, 2023
@galipremsagar galipremsagar linked an issue Apr 12, 2023 that may be closed by this pull request
[BUG] Series created from scalar and index is invalid #13056
Closed
vyasr
vyasr requested changes Apr 12, 2023
View reviewed changes
python/cudf/cudf/core/series.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/indexed_frame.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/series.py Show resolved Hide resolved
@galipremsagar galipremsagar requested a review from vyasr April 13, 2023 23:02
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Apr 13, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 2d70331 into rapidsai:branch-23.06 Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@shwina shwina Awaiting requested review from shwina shwina is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
2 participants
@galipremsagar @vyasr