Set null-count in linked_column_view conversion operator #13121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
3 - Ready for Review
davidwendt
commented
Apr 11, 2023
| @@ -0,0 +1,61 @@ | |||
| /* | |||
There was a problem hiding this comment.
This code moved from the .hpp file
vyasr
approved these changes
Apr 12, 2023
| this->size(), | ||
| this->head(), | ||
| this->null_mask(), | ||
| this->null_count(), |
There was a problem hiding this comment.
This is the only change I see aside from the move (and it looks correct). Please re-request review if there is any other substantive change that I missed.
ttnghia
reviewed
Apr 13, 2023
ttnghia
reviewed
Apr 13, 2023
ttnghia
approved these changes
Apr 14, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the
UNKNOWN_NULL_COUNTusage in thelinked_column_view::column_view()conversion operator. The null-count is copied from the parent instance. Thelinked_column_viewclass was reworked to move the C++ function definitions from the header file to a new .cpp file.Contributes to: #11968
Checklist