Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix missing confluent kafka version #13101

Merged
merged 4 commits into from
Apr 10, 2023

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Apr 10, 2023

Description

This PR fixes missing python-confluent-kafka version changes in custreamz and removes python-confluent-kafka from cudf_kafka because I don't see any usage of confluent_kafka in the python code.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar requested a review from a team as a code owner April 10, 2023 16:13
@github-actions github-actions bot added the conda label Apr 10, 2023
@galipremsagar
Copy link
Contributor Author

cc: @bdice @jdye64

@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels Apr 10, 2023
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to push to this branch to update

cudf/dependencies.yaml

Lines 394 to 402 in ebe4757

run_cudf_kafka:
common:
- output_types: conda
packages:
- python-confluent-kafka>=1.9.0,<1.10.0a0
- output_types: [requirements, pyproject]
packages:
- *cudf
- confluent-kafka>=1.9.0,<1.10.0a0
. We need to move this dependency to the run_custreamz section.

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the dependencies.yaml. Should be good to go.

@galipremsagar
Copy link
Contributor Author

Thanks @bdice !

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Apr 10, 2023
@galipremsagar galipremsagar self-assigned this Apr 10, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner April 10, 2023 16:49
@github-actions github-actions bot added the Python Affects Python cuDF API. label Apr 10, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5e41c1f into rapidsai:branch-23.06 Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants