Use make_empty_lists_column instead of make_empty_column(type_id::LIST) #13099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
ttnghia
approved these changes
Apr 10, 2023
3 tasks
ajschmidt8
approved these changes
Apr 10, 2023
… bug-make-empty-list
vyasr
approved these changes
Apr 11, 2023
That is correct. I thought I had a test for this as well but missed this case. |
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 13, 2023
Resolves #11754. The `byte_cast` function is creating unsanitized lists from null inputs, which is a bug. [This logic](https://github.com/rapidsai/cudf/blob/9c06330363db4da99803a3728b8bf44f9829f0b9/cpp/src/reshape/byte_cast.cu#L66-L81) copies nonzero bytes even if the input element is null. The input's null mask is copied onto the output parent list column, but the null children are nonempty. This PR fixes the bug by calling `cudf::purge_nonempty_nulls` on the result before returning, if there are any nulls to be purged. Depends on: * #13099 Authors: - Bradley Dice (https://github.com/bdice) - Nghia Truong (https://github.com/ttnghia) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - David Wendt (https://github.com/davidwendt) - Vyas Ramasubramani (https://github.com/vyasr) - Mike Wilson (https://github.com/hyperbolic2346) URL: #11971
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug where
cudf::make_empty_column(type_id::LIST)is called and adds a gtests to check for this error.The
make_empty_columncannot accept a nested type because it requires a child type. The internalmake_empty_lists_columnis moved to thelists_column_factories.hppheader which is itself moved to thecpp/include/cudf/lists/detaildirectory since it only contains detail functions.Closes #13096
Checklist