Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove using namespace cudf; from libcudf gtests source #13089

Merged

Conversation

davidwendt
Copy link
Contributor

Description

Removes using namespace cudf; from gtests source code to make it easier to read -- find where utilities and function calls are implemented. Also removed a few using namespace cudf::test; usages which by extension includes namespace cudf.

Found these while working on #13081
Reference #11734

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress code quality libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 7, 2023
@davidwendt davidwendt self-assigned this Apr 7, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Apr 7, 2023
@davidwendt davidwendt marked this pull request as ready for review April 10, 2023 12:51
@davidwendt davidwendt requested a review from a team as a code owner April 10, 2023 12:51
@davidwendt davidwendt requested review from bdice and vuule April 10, 2023 12:51
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 73c8d16 into rapidsai:branch-23.06 Apr 11, 2023
@davidwendt davidwendt deleted the remove-using-namespace-cudf branch April 11, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants