Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix column selection read_parquet benchmarks #13082

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Apr 6, 2023

Description

Helper function get_col_names in the Parquet reader benchmarks throws with nested columns. It should instead just ignore the children columns and return the top-level colum names.
Also renamed the function to better reflect what it does.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule added bug Something isn't working non-breaking Non-breaking change labels Apr 6, 2023
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Apr 6, 2023
@vuule vuule changed the title fix + rename Fix column selection read_parquet benchmarks Apr 6, 2023
@vuule vuule marked this pull request as ready for review April 6, 2023 22:23
@vuule vuule requested a review from a team as a code owner April 6, 2023 22:23
@vuule vuule requested review from vyasr and bdice April 6, 2023 22:23
@vuule vuule self-assigned this Apr 6, 2023
@vuule vuule added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Apr 6, 2023
@vuule
Copy link
Contributor Author

vuule commented Apr 7, 2023

/merge

@rapids-bot rapids-bot bot merged commit 46b5900 into rapidsai:branch-23.06 Apr 7, 2023
@vuule vuule deleted the bug-bm-get_col_names-nested branch April 7, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants