-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assert for non-empty nulls #13071
Assert for non-empty nulls #13071
Conversation
Added assert check to ColumnView creation and appropriate changes to bypass the check for tests
Would you mind taking a look at this when you have time. This addresses the issue of imported data having non-empty nulls. I just had to add another system property for the unit-tests to pass. PTAL |
There seem to be sync problems from the fork and the latest changes are not showing here. |
CI failure has nothing to do with the changes in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit.
@revans2 I wanted to see what you think about this. Considering this is something that CUDF requires and assertions in Java aren't enabled by default, should we transition this to a hard check and throw an Exception instead of using an assert? We can do this at a later time too, I just wanted to know if we need a follow-on issue for this. |
We want the assertion off in production because checking if they are empty involves launching at least one kernel and is rather expensive. Having it be an assertion lets us verify that it is doing the right thing in tests, but we get the performance in production. It also lets us enable it in production if we think there is a problem. That said, in some cases where we know that we would get data corruption if we get a non-empty null, it is probably worth doing a check and then fixing the problem, at least until we feel comfortable enough that we have fixed all of the issues. |
rebuild |
/merge |
…FileTest and CudaFatalTest (#13213) As part of #13071 changes were made to add tests that will fail unless assertions are off for those tests. This PR adds `ColumnViewNonEmptyNullsTest` to the list of skipped tests Authors: - Raza Jafri (https://github.com/razajafri) Approvers: - Jason Lowe (https://github.com/jlowe) URL: #13213
Added assert check to ColumnView creation to ensure there are no non-empty nulls at the time of creation. This also contains changes to bypass this check by setting
-da:ai.rapids.cudf.AssertEmptyNulls
.Description
Checklist