[WIP] Test changes in RMM PR 1241 #13064
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 5, 2023
The identify_stream_usage test uses `strcmp` but not does not include `<cstring>`. This PR fixes that. The missing include was surfaced by #13064, showing that the test relied on headers in `spdlog` to include `cstring`. Authors: - Allard Hendriksen (https://github.com/ahendriksen) - Bradley Dice (https://github.com/bdice) Approvers: - Bradley Dice (https://github.com/bdice) - Nghia Truong (https://github.com/ttnghia) URL: #13066
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 5, 2023
`data_sink.hpp` uses `std::transform` but not does not include <algorithm>. This PR fixes that. The missing include was surfaced by #13064. Authors: - Allard Hendriksen (https://github.com/ahendriksen) Approvers: - Bradley Dice (https://github.com/bdice) - David Wendt (https://github.com/davidwendt) - Nghia Truong (https://github.com/ttnghia) URL: #13068
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream changes: rapidsai/rmm#1241