[REVIEW] Add notes to performance comparisons notebook #13044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
improvement
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
galipremsagar
changed the title
galipremsagar
commented
Mar 30, 2023
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "This notebook compares the performance of `cuDF` and `pandas`. The comparisons performed are on identical data sizes. This notebook primarily showcases the factor\n", | ||
| "of speedups users can have when the similar `pandas` APIs are run on GPUs using `cudf`.\n", | ||
| "\n", | ||
| "The hardware details used to run these performance comparisons are at the end of this page." | ||
| "The hardware details used to run these performance comparisons are at the end of this page.\n", |
There was a problem hiding this comment.
I've verified this claim holds true on a T4 by running the entire notebook after slashing the data-sizes in half.
bdice
reviewed
Mar 31, 2023
docs/cudf/source/user_guide/performance_comparisons/performance-comparisons.ipynb
Outdated
Show resolved
Hide resolved
…e-comparisons.ipynb Co-authored-by: Bradley Dice <[email protected]>
bdice
reviewed
Mar 31, 2023
bdice
approved these changes
Mar 31, 2023
…cudf into update_notes_perf
raydouglass
approved these changes
Mar 31, 2023
vyasr
approved these changes
Mar 31, 2023
galipremsagar
added
the
5 - Ready to Merge
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
notesection to the performance comparisons notebook to give users a disclaimer on what they need to do to run this notebook on lower-end hardware.Checklist