Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable binary operations between scalars and columns of differing decimal types #13034

Merged
merged 10 commits into from
Apr 15, 2023
Merged

Enable binary operations between scalars and columns of differing decimal types #13034

merged 10 commits into from
Apr 15, 2023

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Mar 29, 2023

Closes #12958

This PR enables some previously xfailing tests.

@shwina shwina requested a review from a team as a code owner March 29, 2023 17:38
@shwina shwina changed the base branch from branch-23.04 to branch-23.06 March 29, 2023 17:38
@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 29, 2023
@shwina shwina added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 29, 2023
shwina
shwina commented Mar 29, 2023
View reviewed changes
Copy link
Contributor Author

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes

@shwina
Copy link
Contributor Author

shwina commented Apr 14, 2023

/merge

@rapids-bot rapids-bot bot merged commit 0b59fda into rapidsai:branch-23.06 Apr 15, 2023
@shwina shwina mentioned this pull request Apr 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller left review comments

@galipremsagar galipremsagar galipremsagar approved these changes

@bdice bdice bdice approved these changes

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Support binary ops between decimal columns and scalars
5 participants
@shwina @vyasr @bdice @galipremsagar @brandon-b-miller