Fix OOB memory access in CSV reader when reading without NA values #13011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
bug
ttnghia
reviewed
Apr 5, 2023
| @@ -83,8 +83,8 @@ trie create_serialized_trie(const std::vector<std::string>& keys, rmm::cuda_stre | |||
| __host__ __device__ inline bool serialized_trie_contains(device_span<serial_trie_node const> trie, | |||
| device_span<char const> key) | |||
| { | |||
| if (trie.data() == nullptr || trie.empty()) return false; | |||
| if (key.empty()) return trie.front().is_leaf; | |||
| if (trie.empty()) { return false; } | |||
There was a problem hiding this comment.
What's wrong with trie.data() == nullptr?
There was a problem hiding this comment.
I assume it's strictly redundant since a device span with data() == nullptr will always have size 0.
vyasr
approved these changes
Apr 5, 2023
| @@ -83,8 +83,8 @@ trie create_serialized_trie(const std::vector<std::string>& keys, rmm::cuda_stre | |||
| __host__ __device__ inline bool serialized_trie_contains(device_span<serial_trie_node const> trie, | |||
| device_span<char const> key) | |||
| { | |||
| if (trie.data() == nullptr || trie.empty()) return false; | |||
| if (key.empty()) return trie.front().is_leaf; | |||
| if (trie.empty()) { return false; } | |||
There was a problem hiding this comment.
I assume it's strictly redundant since a device span with data() == nullptr will always have size 0.
ttnghia
approved these changes
Apr 5, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CSV reader uses a trie to read field with special values as nulls. The creation of the trie does not work correctly when there are not special values. This can happen when the NA filter is enabled, but the default NA values are removed, and user does not specify custom values. In this case, use of this trie leads to OOB memory access.
This PR fixes the trie creation to create an empty trie when there are not special values to look for.
Included a C++ test that crashes without the fix.
Checklist