-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin numba version #13001
Pin numba version #13001
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were some CUDA-related fixes for extensions that went into Numba 0.56.4 - while we're here could / should we bump it to >=0.56.4,<0.57
?
FWIW, <0.57
looks like the correct upper bound to me from a Numba standpoint but I can't vouch for the changes (whether there's other locations that need changing in cudf).
@gmarkall @brandon-b-miller @vyasr Can we cross-link an issue describing the problem with Record types / UDFs? Anything to document why we’re pinning in a little more detail, so that we can resolve it later when 0.57 is out and have everything link together. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (from the perspective of the Numba version ranges).
/merge |
Description
Changes in the upcoming numba 0.57 release will break cudf until we've had time to adapt them, which will not happen in 23.04.
Checklist