Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fix DataFrame constructor to broadcast scalar inputs properly #12997

Merged
merged 6 commits into from
Mar 23, 2023
Merged

[REVIEW] Fix DataFrame constructor to broadcast scalar inputs properly #12997

merged 6 commits into from
Mar 23, 2023

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Mar 23, 2023 •
edited by wence-
Loading

Description

Fixes: #12646

This PR fixes an issue with DataFrame where broadcasting scalar inputs was order dependent.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Mar 23, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner March 23, 2023 04:17
@galipremsagar galipremsagar self-assigned this Mar 23, 2023
@galipremsagar galipremsagar requested review from wence- and isVoid March 23, 2023 04:17
@galipremsagar galipremsagar requested a review from shwina March 23, 2023 04:18
@wence- wence- changed the title [REVIEW] Fix DataFrame constructor to be broadcast scalar inputs properly [REVIEW] Fix DataFrame constructor to broadcast scalar inputs properly Mar 23, 2023
wence-
wence- reviewed Mar 23, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor suggestion, that needn't necessarily be acted on.

python/cudf/cudf/core/dataframe.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/dataframe.py Show resolved Hide resolved
wence-
wence- approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And for fixing my bug...

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Mar 23, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 33e2387 into rapidsai:branch-23.04 Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@shwina shwina Awaiting requested review from shwina

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Broadast of scalar inputs to the same lengths as other columns in DataFrame constructor
2 participants
@galipremsagar @wence-