Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Handle index names while performing groupby #12992

Merged
merged 2 commits into from
Mar 27, 2023
Merged

[REVIEW] Handle index names while performing groupby #12992

merged 2 commits into from
Mar 27, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes: #12759

This PR fixes the above issue by factoring in index names while performing a groupby by label name.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 22, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner March 22, 2023 19:25
@galipremsagar galipremsagar self-assigned this Mar 22, 2023
@galipremsagar galipremsagar removed the improvement Improvement / enhancement to an existing function label Mar 22, 2023
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Needs cuDF (Python) Reviewer labels Mar 27, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit bc7b89f into rapidsai:branch-23.04 Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@skirui-source skirui-source Awaiting requested review from skirui-source skirui-source is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Grouping by an index column throws an error
2 participants
@galipremsagar @shwina