Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add developer documentation forbidding default parameters in detail APIs #12978

Merged
merged 8 commits into from
Mar 22, 2023
Merged

Add developer documentation forbidding default parameters in detail APIs #12978

merged 8 commits into from
Mar 22, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Mar 20, 2023 •
edited
Loading

Description

Resolves #12944. Also reflows the text to ensure consistent text width.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for Review Ready for review by team doc Documentation libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 20, 2023
@vyasr vyasr requested a review from a team as a code owner March 20, 2023 21:51
@vyasr vyasr self-assigned this Mar 20, 2023
@vyasr vyasr requested review from harrism and vuule March 20, 2023 21:51
@vyasr vyasr removed the improvement Improvement / enhancement to an existing function label Mar 20, 2023
@vyasr
Copy link
Contributor Author

vyasr commented Mar 20, 2023

Technically PRs #12964-#12970 are also required to close the associated issue, but I am assuming that these will be merged within a reasonable amount of time of each other.

harrism
harrism approved these changes Mar 20, 2023
View reviewed changes
cpp/doxygen/developer_guide/DEVELOPER_GUIDE.md Outdated Show resolved Hide resolved
cpp/doxygen/developer_guide/DEVELOPER_GUIDE.md Outdated Show resolved Hide resolved
cpp/doxygen/developer_guide/DEVELOPER_GUIDE.md Outdated Show resolved Hide resolved
cpp/doxygen/developer_guide/DEVELOPER_GUIDE.md Outdated Show resolved Hide resolved
cpp/doxygen/developer_guide/DEVELOPER_GUIDE.md Outdated Show resolved Hide resolved
cpp/doxygen/developer_guide/DEVELOPER_GUIDE.md Outdated Show resolved Hide resolved
cpp/doxygen/developer_guide/DEVELOPER_GUIDE.md Outdated Show resolved Hide resolved
@vyasr
Copy link
Contributor Author

vyasr commented Mar 21, 2023

/merge

@bdice
Copy link
Contributor

bdice commented Mar 21, 2023

This PR is too far behind branch-23.04 to pass the Recently Updated check. I'll update it so that CI can merge when it passes.

@rapids-bot rapids-bot bot merged commit 6e41db0 into rapidsai:branch-23.04 Mar 22, 2023
@vyasr vyasr deleted the doc/default_detail_params branch January 23, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@davidwendt davidwendt davidwendt approved these changes

@PointKernel PointKernel PointKernel approved these changes

@bdice bdice bdice approved these changes

@vuule vuule Awaiting requested review from vuule vuule is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Remove default parameters from detail APIs
5 participants
@vyasr @bdice @harrism @PointKernel @davidwendt