Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move detail reduction functions to cudf::reduction::detail namespace #12971

Merged
merged 13 commits into from
Mar 23, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Moves internal/detail reduction (and segmented reduction) functions and other declarations from the cudf::detail namespace to the cudf::reduction::detail namespace. The detail function headers also moved from cpp/include/cudf/detail to cpp/include/cudf/reduction/detail directory.
The public header cpp/include/cudf/reduction.hpp was not changed or moved.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 17, 2023
@davidwendt davidwendt self-assigned this Mar 17, 2023
@github-actions github-actions bot added the conda label Mar 17, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Mar 20, 2023
@davidwendt davidwendt marked this pull request as ready for review March 20, 2023 12:37
@davidwendt davidwendt requested review from a team as code owners March 20, 2023 12:37
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Unfortunately the removal of default mrs conflicted with my PR so this one will need some minor updating, but then should be good to go.

Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 90d2cb1 into rapidsai:branch-23.04 Mar 23, 2023
@davidwendt davidwendt deleted the fix-reduction-detail-ns branch March 23, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants