-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move detail reduction functions to cudf::reduction::detail namespace #12971
Move detail reduction functions to cudf::reduction::detail namespace #12971
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM. Unfortunately the removal of default mrs conflicted with my PR so this one will need some minor updating, but then should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving ops-codeowner
file changes
/merge |
Description
Moves internal/detail reduction (and segmented reduction) functions and other declarations from the
cudf::detail
namespace to thecudf::reduction::detail
namespace. The detail function headers also moved fromcpp/include/cudf/detail
tocpp/include/cudf/reduction/detail
directory.The public header
cpp/include/cudf/reduction.hpp
was not changed or moved.Checklist