Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default detail mrs: part5 #12968

Merged
merged 10 commits into from
Mar 21, 2023
Merged

Remove default detail mrs: part5 #12968

merged 10 commits into from
Mar 21, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Mar 17, 2023

Description

This is the fifth PR in a sequence removing default mr parameters in detail APIs. Contributes to #12944.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 17, 2023
@vyasr vyasr self-assigned this Mar 17, 2023
@vyasr vyasr requested a review from a team as a code owner March 17, 2023 19:04
@vyasr vyasr requested review from mythrocks and nvdbaranec March 17, 2023 19:04
mythrocks
mythrocks approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vyasr
Copy link
Contributor Author

vyasr commented Mar 21, 2023

/merge

@rapids-bot rapids-bot bot merged commit 6547d96 into rapidsai:branch-23.04 Mar 21, 2023
@vyasr vyasr deleted the feat/remove_detail_mr_default_parameters_part5 branch March 21, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mythrocks mythrocks mythrocks approved these changes

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyasr @mythrocks