-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use rapids-export(COMPONENTS) feature. #12959
Update to use rapids-export(COMPONENTS) feature. #12959
Conversation
Not only does this simplify the `cudf` CMakeLists.txt it removes a bug where we failed to install the testing dependencies file since it relied on internal rapids-cmake details.
Is the export name being set here clashing with the "nice" export name in rapids-cmake, leading to trying to install an export set that doesn't actually exist? |
Maybe? What failures are you looking at. I can't see what is going wrong in the wheel builds |
It's failing with
(you have to expand some in-text dropdowns or open the raw log). |
The "nice" name is only used for the files rapids-CMake generates. What this looks like is that for some builds we disable cudf test util from being built, but we are always trying to export it. |
Good catch. Pushed the fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that pulling in this fix resolves #12976.
/merge |
Description
Not only does this simplify the
cudf
CMakeLists.txt it removes a bug where we failed to install the testing dependencies file since it relied on internal rapids-cmake details.Expected to fix the following:
Fixes #12976
Checklist