Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare a different name for nan_equality.UNEQUAL to prevent Cython warnings. #12947

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Mar 14, 2023

Description

Closes #9462.

warning: cudf/_lib/cpp/types.pxd:51:8: 'UNEQUAL' redeclared

We've been dealing with warnings like this for as long as I've worked on cudf. I think it'd be good to fix this by renaming the Cython enum. We don't rely on this name very much at the Cython/Python level, so it's a small change. (This has been irking me for a long time and I want to see this warning go away in the build logs.)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner March 14, 2023 21:39
@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 14, 2023
@bdice bdice added improvement Improvement / enhancement to an existing function breaking Breaking change labels Mar 16, 2023
@bdice bdice self-assigned this Mar 16, 2023
@bdice
Copy link
Contributor Author

bdice commented Mar 17, 2023

/merge

@rapids-bot rapids-bot bot merged commit 49e87b8 into rapidsai:branch-23.04 Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cython enums for null_equality and nan_equality redeclare 'UNEQUAL', raising a warning during builds.
2 participants