Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining default stream parameters #12943

Merged
merged 8 commits into from
Mar 15, 2023
Merged

Remove remaining default stream parameters #12943

merged 8 commits into from
Mar 15, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Mar 14, 2023

Description

This PR closes #9854, removing all default stream parameters in detail APIs. This increases stream-safety by removing the ability to accidentally use the default stream when a detail API is called without an explicit stream parameter when a user-provided stream should have been passed through.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 14, 2023
@vyasr vyasr added this to the Enable streams milestone Mar 14, 2023
@vyasr vyasr requested a review from a team as a code owner March 14, 2023 19:08
@vyasr vyasr self-assigned this Mar 14, 2023
@vyasr vyasr requested review from PointKernel and davidwendt March 14, 2023 19:08
@vyasr vyasr mentioned this pull request Mar 14, 2023
Closed
bdice
bdice approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

cpp/tests/rolling/range_window_bounds_test.cpp Outdated Show resolved Hide resolved
PointKernel
PointKernel approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vyasr
Copy link
Contributor Author

vyasr commented Mar 15, 2023

/merge

@rapids-bot rapids-bot bot merged commit dfa9e93 into rapidsai:branch-23.04 Mar 15, 2023
@vyasr vyasr deleted the feat/remove_detail_stream_default_parameters branch March 15, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@PointKernel PointKernel PointKernel approved these changes

@bdice bdice bdice approved these changes

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
Enable streams
Development

Successfully merging this pull request may close these issues.

[FEA] Consider removing default value from stream parameter in detail functions.
4 participants
@vyasr @bdice @PointKernel @davidwendt