Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cudf::segmented_reduce gtest for ANY aggregation #12940

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Fix cudf::segmented_reduce gtest for ANY aggregation #12940

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
366b82e
Fix cudf::segmented_reduce gtest for ANY aggregation
davidwendt Mar 14, 2023
b99c028
fix style violation
davidwendt Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 9 additions & 20 deletions cpp/tests/reductions/segmented_reduction_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,36 +251,25 @@ TYPED_TEST(SegmentedReductionTest, AnyExcludeNulls)
{false, false, true, true, bool{XXX}, false, true, bool{XXX}, bool{XXX}},
{true, true, true, true, false, true, true, false, false}};

auto res =
cudf::segmented_reduce(input,
d_offsets,
*cudf::make_any_aggregation<cudf::segmented_reduce_aggregation>(),
cudf::data_type{cudf::type_id::BOOL8},
cudf::null_policy::EXCLUDE);
auto const agg = cudf::make_any_aggregation<cudf::segmented_reduce_aggregation>();
auto const output_type = cudf::data_type{cudf::type_id::BOOL8};
auto const policy = cudf::null_policy::EXCLUDE;

auto res = cudf::segmented_reduce(input, d_offsets, *agg, output_type, policy);
CUDF_TEST_EXPECT_COLUMNS_EQUAL(*res, expect);

// Test with initial value
auto const init_scalar = cudf::make_fixed_width_scalar<TypeParam>(1);
auto const init_scalar = cudf::make_fixed_width_scalar<TypeParam>(0);
auto const init_expect = cudf::test::fixed_width_column_wrapper<bool>{
{true, true, true, true, true, true, true, true, true},
{false, false, true, true, false, false, true, false, false},
{true, true, true, true, true, true, true, true, true}};

res = cudf::segmented_reduce(input,
d_offsets,
*cudf::make_any_aggregation<cudf::segmented_reduce_aggregation>(),
cudf::data_type{cudf::type_id::BOOL8},
cudf::null_policy::EXCLUDE,
*init_scalar);
res = cudf::segmented_reduce(input, d_offsets, *agg, output_type, policy, *init_scalar);
CUDF_TEST_EXPECT_COLUMNS_EQUAL(*res, init_expect);

// Test with null initial value
init_scalar->set_valid_async(false);
res = cudf::segmented_reduce(input,
d_offsets,
*cudf::make_any_aggregation<cudf::segmented_reduce_aggregation>(),
cudf::data_type{cudf::type_id::BOOL8},
cudf::null_policy::EXCLUDE,
*init_scalar);
res = cudf::segmented_reduce(input, d_offsets, *agg, output_type, policy, *init_scalar);
CUDF_TEST_EXPECT_COLUMNS_EQUAL(*res, expect);
}

Expand Down