Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use get_current_device_resource for intermediate allocations in COLLECT_LIST window code #12927

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cpp/src/rolling/detail/rolling_collect_list.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ std::unique_ptr<column> create_collect_offsets(size_type input_size,
{
// Materialize offsets column.
auto static constexpr size_data_type = data_type{type_to_id<size_type>()};
auto sizes =
make_fixed_width_column(size_data_type, input_size, mask_state::UNALLOCATED, stream, mr);
auto sizes = make_fixed_width_column(size_data_type, input_size, mask_state::UNALLOCATED, stream);
auto mutable_sizes = sizes->mutable_view();

// Consider the following preceding/following values:
Expand Down