Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark dlpack tensor deleter as noexcept to match PyCapsule_Destructor signature. #12921

Merged
merged 3 commits into from
Mar 15, 2023
Merged

Mark dlpack tensor deleter as noexcept to match PyCapsule_Destructor signature. #12921

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14ec4ef
Explicitly cast dlpack tensor deleter to PyCapsule_Destructor.
bdice Mar 10, 2023
b3ceec9
Match deleter signature with noexcept.
bdice Mar 14, 2023
e8d0d57
Merge branch 'branch-23.04' into pycapsule-destructor-cast
shwina Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/cudf/cudf/_lib/interop.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2020-2022, NVIDIA CORPORATION.
# Copyright (c) 2020-2023, NVIDIA CORPORATION.

from cpython cimport pycapsule
from libcpp.memory cimport shared_ptr, unique_ptr
Expand Down Expand Up @@ -70,7 +70,7 @@ def to_dlpack(list source_columns):
)


cdef void dlmanaged_tensor_pycapsule_deleter(object pycap_obj):
cdef void dlmanaged_tensor_pycapsule_deleter(object pycap_obj) noexcept:
wence- marked this conversation as resolved.
Show resolved Hide resolved
cdef DLManagedTensor* dlpack_tensor = <DLManagedTensor*>0
try:
dlpack_tensor = <DLManagedTensor*>pycapsule.PyCapsule_GetPointer(
Expand Down