Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conda recipe post-link.sh typo #12916

Merged
merged 3 commits into from
Mar 21, 2023

Conversation

pentschev
Copy link
Member

@pentschev pentschev commented Mar 9, 2023

Description

Following an internal discussion, fix a typo in conda recipe post-link.sh. For some conda versions relying solely on prelink_message is insufficient, thus this file has to still be maintained.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@pentschev pentschev requested a review from a team as a code owner March 9, 2023 14:59
@github-actions github-actions bot added the conda label Mar 9, 2023
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until we hear from @jakirkham on whether we can delete this file altogether in favor of the prelink message alone or whether the post-link script is still needed for some conda versions that we care about.

@vyasr vyasr added bug Something isn't working non-breaking Non-breaking change labels Mar 17, 2023
@vyasr
Copy link
Contributor

vyasr commented Mar 17, 2023

/merge

@rapids-bot rapids-bot bot merged commit 84ac1d5 into rapidsai:branch-23.04 Mar 21, 2023
@pentschev pentschev deleted the fix-conda-post-link branch November 19, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants