Fix benchmarks coded in namespace cudf and using namespace cudf #12915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikeyann
added
3 - Ready for Review
davidwendt
approved these changes
Mar 9, 2023
divyegala
approved these changes
Mar 9, 2023
Comment on lines
+44
to
+46
| const cudf::size_type base_size{(cudf::size_type)state.range(0)}; | ||
| const cudf::size_type num_elements_per_row{(cudf::size_type)state.range(1)}; | ||
| const auto num_rows = (cudf::size_type)ceil(double(base_size) / num_elements_per_row); |
There was a problem hiding this comment.
I don't know if it's in the guide, but I have seen libcudf devs using east-const by default. However, if it's a matter of personal preference then it's fine with me
There was a problem hiding this comment.
Recommend to change that too.
ttnghia
approved these changes
Mar 9, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes BINARYOP_BENCH, GROUPBY_NVBENCH benchmarks from using namespace cudf directly.
Fixes SCATTER_LISTS_BENCH benchmarks coded in namespace cudf
Reference #11734
Checklist