Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FST, JSON gtests & benchmarks coded in namespace cudf::test #12907

Merged
merged 4 commits into from
Mar 9, 2023
Merged

Fix FST, JSON gtests & benchmarks coded in namespace cudf::test #12907

merged 4 commits into from
Mar 9, 2023

Conversation

karthikeyann
Copy link
Contributor

Description

Fixes FST_TEST gtests source files coded in namespace cudf::test
Fixes NESTED_JSON_TEST gtests source files coded in namespace cudf::test, and fixes using cudf::io::json namespace
Fixes FST_NVBENCH benchmark coded in namespace cudf

Reference #11734

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@karthikeyann karthikeyann added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 8, 2023
@karthikeyann karthikeyann requested a review from a team as a code owner March 8, 2023 20:16
@karthikeyann karthikeyann self-assigned this Mar 8, 2023
PointKernel
PointKernel approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karthikeyann
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit ff96cd1 into rapidsai:branch-23.04 Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@PointKernel PointKernel PointKernel approved these changes

@elstehle elstehle elstehle approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@karthikeyann karthikeyann

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karthikeyann @elstehle @PointKernel @davidwendt