-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate pyproject dependencies using dfg #12906
Generate pyproject dependencies using dfg #12906
Conversation
3a51cfe
to
eeabdba
Compare
8153b6d
to
ae59515
Compare
…ilt as part of libcudf.
…pip and conda environments.
f60a72f
to
2ee8afa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some very small questions, that said, I think this looks fine as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving CMake comment
/merge |
Description
This PR updates cudf to generate all build, run and test dependencies in pyproject.toml using
rapids-dependency-file-generator
. In the process, a few additional relevant changes were made:rapids-dependency-file-generator
if we should choose to do so.Checklist