Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate pyproject dependencies using dfg #12906

Merged
merged 25 commits into from
Mar 15, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Mar 8, 2023

Description

This PR updates cudf to generate all build, run and test dependencies in pyproject.toml using rapids-dependency-file-generator. In the process, a few additional relevant changes were made:

  • dependencies.yaml was refactored to more precisely capture the requirements of the different packages in the repo as well as more accurately separate the build/run/test dependencies. This should facilitate generation of meta.yaml dependencies with rapids-dependency-file-generator if we should choose to do so.
  • cudf_kafka's setup.py had as much logic as possible moved to pyproject.toml without having to change the way that extension modules are built. This package is somewhat unique within RAPIDS in having a C++ component that we have not converted to scikit-build because we have no plans for wheels there at this time. As a result, it was not previously converted to a pyproject.toml-driven build (classic Cython builds are not compatible with pyproject.toml-driven builds).
  • A tiny unrelated fix to the Java build that removed an outdated CMake flag.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 8, 2023
@vyasr vyasr self-assigned this Mar 8, 2023
@vyasr vyasr force-pushed the feat/pyproject_dependencies branch from 3a51cfe to eeabdba Compare March 9, 2023 03:24
@github-actions github-actions bot added ci Python Affects Python cuDF API. and removed ci labels Mar 9, 2023
@vyasr vyasr force-pushed the feat/pyproject_dependencies branch 3 times, most recently from 8153b6d to ae59515 Compare March 10, 2023 17:55
@vyasr vyasr force-pushed the feat/pyproject_dependencies branch from f60a72f to 2ee8afa Compare March 10, 2023 20:06
@vyasr vyasr added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Mar 10, 2023
@vyasr vyasr marked this pull request as ready for review March 10, 2023 22:01
@vyasr vyasr requested review from a team as code owners March 10, 2023 22:02
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very small questions, that said, I think this looks fine as is.

ci/test_java.sh Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
dependencies.yaml Show resolved Hide resolved
dependencies.yaml Show resolved Hide resolved
.github/workflows/pr.yaml Show resolved Hide resolved
Copy link
Contributor

@msadang msadang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vyasr vyasr requested a review from a team as a code owner March 15, 2023 13:36
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Mar 15, 2023
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving CMake comment

@vyasr
Copy link
Contributor Author

vyasr commented Mar 15, 2023

/merge

@rapids-bot rapids-bot bot merged commit 3c72eb0 into rapidsai:branch-23.04 Mar 15, 2023
@vyasr vyasr deleted the feat/pyproject_dependencies branch March 15, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants