Fix moto env vars & pass AWS_SESSION_TOKEN to conda builds
#12902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds some additional AWS related environment variable mocks to the `cudf` `pytest`s. These environment variables are documented by `moto` here: https://docs.getmoto.org/en/latest/docs/getting_started.html#recommended-usage. This is important because of some recent CI changes that we made which now populate the `AWS_SESSION_TOKEN` environment variable, which was not mocked prior to the changes in this PR.
ajschmidt8
added
improvement
galipremsagar
approved these changes
Mar 8, 2023
bdice
reviewed
Mar 8, 2023
this matches the `moto` official example here: https://docs.getmoto.org/en/latest/docs/getting_started.html#example-on-usage
bdice
approved these changes
Mar 8, 2023
ajschmidt8
changed the title
motomoto env vars & pass AWS_SESSION_TOKEN to conda builds
jjacobelli
approved these changes
Mar 8, 2023
raydouglass
approved these changes
Mar 8, 2023
3 tasks
galipremsagar
added
the
5 - Ready to Merge
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some additional AWS related environment variable mocks to the
cudfpytests.These environment variables are documented by
motohere: https://docs.getmoto.org/en/latest/docs/getting_started.html#recommended-usage.This is important because of some recent CI changes that we made which now populate the
AWS_SESSION_TOKENenvironment variable, which was not mocked prior to the changes in this PR.Additionally, this PR adds the
AWS_SESSION_TOKENvalue to thescript_envlists for our conda recipes so that it's value is passed through to builds. I also alphabetized thescript_envlists.Checklist