Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate line_terminator in favor of lineterminator in to_csv #12896

Merged
merged 7 commits into from
Mar 8, 2023

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Mar 7, 2023

Description

Pandas 1.5 deprecated line_terminator in favour of lineterminator (to align with read_csv), and removed it in 2.0. Align the cuDF API by preferring lineterminator and providing a deprecation warning for use of line_terminator. Closes #12894.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Pandas 1.5 deprecated line_terminator in favour of lineterminator (to
align with read_csv), and removed it in 2.0. Align the cuDF API by
preferring lineterminator and providing a deprecation warning for use
of line_terminator. Closes rapidsai#12894.
@wence- wence- requested a review from a team as a code owner March 7, 2023 17:18
@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 7, 2023
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor doc suggestion.

python/cudf/cudf/core/dataframe.py Outdated Show resolved Hide resolved
python/cudf/cudf/utils/ioutils.py Outdated Show resolved Hide resolved
@galipremsagar galipremsagar changed the title Deprecate line_terminator in favour of lineterminator in to_csv Deprecate line_terminator in favour of lineterminator in to_csv Mar 7, 2023
@galipremsagar
Copy link
Contributor

@wence- Just FYI since I couldn't suggest from GitHub UI, I also made a trivial change to fix formatting: fb0f7a2

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change deprecation labels Mar 7, 2023
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Mar 7, 2023
python/cudf/cudf/core/dataframe.py Outdated Show resolved Hide resolved
Co-authored-by: Bradley Dice <[email protected]>
@bdice bdice changed the title Deprecate line_terminator in favour of lineterminator in to_csv Deprecate line_terminator in favor of lineterminator in to_csv Mar 8, 2023
@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 4497d62 into rapidsai:branch-23.04 Mar 8, 2023
@wence- wence- deleted the wence/fix/issue-12894 branch March 22, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] API mismatch - DataFrame.to_csv line_terminator vs pandas' lineterminator
3 participants