-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate libcudf regex APIs accepting pattern strings directly #12891
Deprecate libcudf regex APIs accepting pattern strings directly #12891
Conversation
Apologize for reordering the declarations in the headers to make doxygen work. They headers look difficult to review now. Essentially there are two APIs one with |
Do you have a timeline to remove the deprecated APIs? |
I was planning to remove them in 23.06.
The compiler will give a deprecation warning. I'm not sure we should warn actual end users. |
Oh, right, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doxygen really spiced this one up :D
/merge |
Description
Deprecates the libcudf regex APIs that do not accept
cudf::strings::regex_program
objects.The libcudf regex functions were converted to accept
regex_program
objects instead of a pattern string and regex-flags directly in PR #11927Most of this is removing calls to the deprecated functions in the gtests.
The declarations in the headers had to be reordered to make the reference links work in the doxygen output.
These deprecated functions will be removed in a future release.
Checklist