Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

min_rows and num_rows are swapped in ComputePageSizes declaration in Parquet reader #12886

Merged
merged 1 commit into from
Mar 6, 2023
+2 −2
Merged

min_rows and num_rows are swapped in ComputePageSizes declaration in Parquet reader #12886

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cpp/src/io/parquet/parquet_gpu.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,8 +445,8 @@ void BuildStringDictionaryIndex(ColumnChunkDesc* chunks,
*
* @param pages All pages to be decoded
* @param chunks All chunks to be decoded
* @param num_rows Maximum number of rows to read
* @param min_rows crop all rows below min_row
* @param num_rows Maximum number of rows to read
* @param compute_num_rows If set to true, the num_rows field in PageInfo will be
* computed
* @param compute_string_sizes If set to true, the str_bytes field in PageInfo will
Expand All @@ -455,8 +455,8 @@ void BuildStringDictionaryIndex(ColumnChunkDesc* chunks,
*/
void ComputePageSizes(hostdevice_vector<PageInfo>& pages,
hostdevice_vector<ColumnChunkDesc> const& chunks,
size_t num_rows,
size_t min_row,
size_t num_rows,
bool compute_num_rows,
bool compute_string_sizes,
rmm::cuda_stream_view stream);
Expand Down