Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parquet writer column_size() should return a size_t #12870

Merged
merged 5 commits into from
Mar 1, 2023
Merged

Parquet writer column_size() should return a size_t #12870

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
93fb4c8
column_size() should return a size_t
etseidl Mar 1, 2023
eb5a47b
Merge branch 'branch-23.04' into feature/fix_col_size
vuule Mar 1, 2023
8200040
Merge branch 'branch-23.04' into feature/fix_col_size
galipremsagar Mar 1, 2023
27b7c28
Update cpp/src/io/parquet/writer_impl.cu
galipremsagar Mar 1, 2023
981ac3d
Update cpp/src/io/parquet/writer_impl.cu
galipremsagar Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cpp/src/io/parquet/writer_impl.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ parquet::Compression to_parquet_compression(compression_type compression)
}
}

galipremsagar marked this conversation as resolved.
Show resolved Hide resolved
size_type column_size(column_view const& column, rmm::cuda_stream_view stream)

galipremsagar marked this conversation as resolved.
Show resolved Hide resolved
size_t column_size(column_view const& column, rmm::cuda_stream_view stream)
{
if (column.size() == 0) { return 0; }

Expand All @@ -99,7 +100,7 @@ size_type column_size(column_view const& column, rmm::cuda_stream_view stream)
cudf::detail::get_value<size_type>(scol.offsets(), 0, stream);
} else if (column.type().id() == type_id::STRUCT) {
auto const scol = structs_column_view(column);
size_type ret = 0;
size_t ret = 0;
for (int i = 0; i < scol.num_children(); i++) {
ret += column_size(scol.get_sliced_child(i), stream);
}
Expand Down